Skip to content

fix: add missing instruction field on sponsor managed forms#971

Merged
smarcet merged 1 commit into
masterfrom
fix/sponsor-managed-form-instructions
Jun 11, 2026
Merged

fix: add missing instruction field on sponsor managed forms#971
smarcet merged 1 commit into
masterfrom
fix/sponsor-managed-form-instructions

Conversation

@tomrndom

@tomrndom tomrndom commented Jun 11, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown

ref: https://app.clickup.com/t/86baayr5u

Signed-off-by: Tomás Castillo tcastilloboireau@gmail.com

Summary by CodeRabbit

  • Bug Fixes
    • Sponsor-managed forms now include instruction content when fetching form data.

@tomrndom
fix: add missing instruction field on sponsor managed forms
b9621c3 
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
@tomrndom tomrndom requested a review from smarcet June 11, 2026 14:55
@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 99ecb365-93be-43e4-ba98-9993d317461b

📥 Commits

Reviewing files that changed from the base of the PR and between 415be12 and b9621c3.

📒 Files selected for processing (1)
  • src/actions/sponsor-forms-actions.js
📝 Walkthrough

Walkthrough

The pull request extends the getSponsorManagedForm function to request an additional instructions field from the managed forms API. This single-line change adds instruction content to the data shape returned by the "get one" managed forms endpoint.

Changes

Sponsor Forms Instructions Field

Layer / File(s) Summary
API instructions field request
src/actions/sponsor-forms-actions.js		 getSponsorManagedForm adds instructions to the API fields parameter to retrieve instruction content alongside other managed-form data.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • fntechgit/summit-admin#766: Both PRs add/require the instructions field for sponsor managed/forms handling—main PR extends the getSponsorManagedForm API fields to return instructions, while retrieved PR makes instructions mandatory in sponsor forms validation.

Suggested reviewers

  • smarcet

Poem

🐰 A field so small, yet filled with care,
Instructions now float through the air,
One little line, a request so bright,
Managed forms glow with newfound light!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding the missing instructions field to sponsor managed forms.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sponsor-managed-form-instructions

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

Comment @coderabbitai help to get the list of available commands and usage tips.

smarcet
smarcet approved these changes Jun 11, 2026
View reviewed changes

@smarcet smarcet left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet smarcet merged commit 569f1d7 into master Jun 11, 2026
8 of 9 checks passed
smarcet pushed a commit that referenced this pull request Jun 11, 2026
@tomrndom @smarcet
fix: add missing instruction field on sponsor managed forms (#971)
d751ffb 
Signed-off-by: Tomás Castillo <tcastilloboireau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smarcet smarcet smarcet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomrndom @smarcet